Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overrides files not work #901

Merged
merged 2 commits into from
Jul 16, 2021
Merged

Fix overrides files not work #901

merged 2 commits into from
Jul 16, 2021

Conversation

fyangstudio
Copy link
Collaborator

  • Support add extends and plugins config.
  • Fix overrides files not work, like:
    const { getESLintConfig } = require('@iceworks/spec');
    
    module.exports = getESLintConfig('react-ts', {
      overrides: [
        {
          files: ['**/src/apis/**'],
          rules: {
            'react-hooks/rules-of-hooks': 0,
          },
        },
      ]
    });

Because cwd is not current project path.

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2021

Codecov Report

Merging #901 (3c583e0) into release/1.3.0 (2c3e7e4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           release/1.3.0     #901   +/-   ##
==============================================
  Coverage          57.14%   57.14%           
==============================================
  Files                  1        1           
  Lines                 70       70           
  Branches              15       15           
==============================================
  Hits                  40       40           
  Misses                30       30           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c3e7e4...3c583e0. Read the comment docs.

@luhc228 luhc228 merged commit fe359e4 into release/1.3.0 Jul 16, 2021
@fyangstudio fyangstudio mentioned this pull request Jul 16, 2021
@fyangstudio fyangstudio deleted the fix-override-glob branch July 23, 2021 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants