TW-76 - Add tested mappings feature #1
+53
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatolond
approved these changes
Oct 20, 2023
lib/apivore/swagger_checker.rb
Outdated
| validate_swagger! | ||
| setup_mappings! | ||
| end | ||
|
|
||
| def load_swagger_doc! | ||
| @swagger = Apivore::Swagger.new(fetch_swagger!) | ||
| def load_swagger_doc!(is_local: false) |
There was a problem hiding this comment.
isn't it better to set @is_local = is_local and then use it further instead of passing it down?
francktrouillez
force-pushed
the
TW-76/add-tested-mappings-feature
branch
from
bbbec15 to
6f4824c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you doing and why
This PR adds the tested mappings feature, required in order to allow the parallelization of specs WITH the use of Apivore (specs split across the controllers, instead of everything in
api_spec.rb).You can go back to the base PR for the context:
This is a request coming from a discussion with @renatolond and @dsusviela that you can find here.
This is blocking for:
The code quality isn't perfect, I agree, but I tried to keep the same spirit as what was already done, no judgment pls
Associated ticket number and/or AirBrake error?
TW-76
Due Date or Desirable Merge
Not urgent, but needs to be tackled before going for the refactor of apivore described in these 2 PRs:
How has this been tested?
Locally with apptweak pointing to this gem.
Anticipated impact
Able to persist the tested mappings in a given file (
/tmp/apivore/tested_mappings.json).How do you plan to monitor the change in prod to make sure it's working?
Check that the gem is working lol
Question
How do we release this new version of the gem? Is this the same process as for
apptweak-utils-ruby? I don't see any tag for the current version, so idk.Checklist
[ ] This has been tested on staging.[ ] My change requires a change to the documentation.[ ] I have updated the documentation accordingly.[ ] My change includes a database modification[ ] I have tested my database modification in staging.[ ] My changes require changes in other components/squads/teams[ ] I already did the changes in the other components or notified the responsible people that the changes need to be done[ ] The needed changes are already deployed or ready to be deployed