Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add controller which reports K8s and OCP version to control-api #133

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

simu
Copy link
Member

@simu simu commented Nov 12, 2024

The controller reconciles clusterversion.config.openshift.io which should be sufficient to detect changes in the K8s/OCP version.

Summary

  • Short summary of what's included in the PR
  • Give special note to breaking changes

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.

@simu simu added the enhancement New feature or request label Nov 12, 2024
@simu simu force-pushed the feat/report-zone-k8s-ocp-version branch from 55cc6f4 to ad6343d Compare November 14, 2024 07:33
@simu simu marked this pull request as ready for review November 14, 2024 08:00
@simu simu requested a review from a team as a code owner November 14, 2024 08:00
Copy link
Contributor

@bastjan bastjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥳

simu added 2 commits November 14, 2024 14:49
The controller reconciles clusterversion.config.openshift.io which
should be sufficient to detect changes in the K8s/OCP version.
@simu simu force-pushed the feat/report-zone-k8s-ocp-version branch from ad6343d to e5a5172 Compare November 14, 2024 13:49
@simu simu merged commit df3247a into master Nov 14, 2024
4 checks passed
@simu simu deleted the feat/report-zone-k8s-ocp-version branch November 14, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants