-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API Server for organizations #6
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glrf
force-pushed
the
feat/organizations
branch
from
January 10, 2022 09:40
90a5bd8
to
d40ce69
Compare
glrf
force-pushed
the
feat/organizations
branch
from
January 10, 2022 09:48
d40ce69
to
01bf0f0
Compare
glrf
force-pushed
the
feat/organizations
branch
from
January 10, 2022 09:50
01bf0f0
to
ee2a4b8
Compare
Also renamed selfsigned to insecure to be more accurate
glrf
force-pushed
the
feat/organizations
branch
from
January 10, 2022 14:22
3d6163b
to
97c450f
Compare
ccremer
reviewed
Jan 10, 2022
tests/golden/insecure/control-api/control-api/01_api_server/01_role.yaml
Outdated
Show resolved
Hide resolved
simu
approved these changes
Jan 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, some small suggestions inline
yq eval -i ".parameter.control_api.apiserver.tls.serverCert = \"${apicert}\"" \ | ||
inventory/classes/${TENANT_ID}/${CLUSTER_ID}.yml | ||
---- | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm missing something along the lines of
cd invenctory/classes/${TENANT_ID}
git add ${CLUSTER_ID}.yml
git commit -m "Configure Control API APIService certificate"
git push origin master
glrf
force-pushed
the
feat/organizations
branch
3 times, most recently
from
January 10, 2022 15:09
c5c79c4
to
27f0314
Compare
Co-authored-by: Chris <github.account@chrigel.net> Co-authored-by: Simon Gerber <simon.gerber@vshn.ch>
glrf
force-pushed
the
feat/organizations
branch
from
January 10, 2022 15:11
27f0314
to
c8f9340
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the deployment of the aggregate API server.
Depends on appuio/control-api#15
Checklist
bug
,enhancement
,documentation
,change
,breaking
,dependency
as they show up in the changelog.