Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API Server for organizations #6

Merged
merged 8 commits into from
Jan 10, 2022
Merged

Add API Server for organizations #6

merged 8 commits into from
Jan 10, 2022

Conversation

glrf
Copy link
Contributor

@glrf glrf commented Jan 10, 2022

This PR adds the deployment of the aggregate API server.

Depends on appuio/control-api#15

Checklist

  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@glrf glrf added the enhancement New feature or request label Jan 10, 2022
@glrf glrf self-assigned this Jan 10, 2022
@glrf glrf force-pushed the feat/organizations branch from 90a5bd8 to d40ce69 Compare January 10, 2022 09:40
@glrf glrf force-pushed the feat/organizations branch from d40ce69 to 01bf0f0 Compare January 10, 2022 09:48
@glrf glrf force-pushed the feat/organizations branch from 01bf0f0 to ee2a4b8 Compare January 10, 2022 09:50
@glrf glrf marked this pull request as ready for review January 10, 2022 09:52
@glrf glrf force-pushed the feat/organizations branch from 3d6163b to 97c450f Compare January 10, 2022 14:22
@glrf glrf requested review from simu and ccremer January 10, 2022 14:26
component/api-server.jsonnet Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/how-tos/tls.adoc Outdated Show resolved Hide resolved
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, some small suggestions inline

component/api-server.jsonnet Outdated Show resolved Hide resolved
yq eval -i ".parameter.control_api.apiserver.tls.serverCert = \"${apicert}\"" \
inventory/classes/${TENANT_ID}/${CLUSTER_ID}.yml
----

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing something along the lines of

cd invenctory/classes/${TENANT_ID}
git add ${CLUSTER_ID}.yml
git commit -m "Configure Control API APIService certificate"
git push origin master

docs/modules/ROOT/pages/references/parameters.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/references/parameters.adoc Outdated Show resolved Hide resolved
@glrf glrf force-pushed the feat/organizations branch 3 times, most recently from c5c79c4 to 27f0314 Compare January 10, 2022 15:09
Co-authored-by: Chris <github.account@chrigel.net>
Co-authored-by: Simon Gerber <simon.gerber@vshn.ch>
@glrf glrf merged commit b2559dd into master Jan 10, 2022
@glrf glrf deleted the feat/organizations branch January 10, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants