Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune fields with null values in user-provided Alertmanager config #191

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

simu
Copy link
Member

@simu simu commented Jan 3, 2024

This allows us to gradually roll out Alertmanager configs with new fields set (e.g. opsgenie_configs.source in a receiver config) even though the receiver config is formatted as a list which isn't easily editable in the hierarchy.

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

@simu simu added the enhancement New feature or request label Jan 3, 2024
@simu simu requested a review from a team as a code owner January 3, 2024 14:47
simu added 2 commits January 3, 2024 15:55
Update golden test outputs to match latest upstream manifests
This allows us to gradually roll out Alertmanager configs with new
fields set (e.g. `opsgenie_configs.source` in a receiver config) even
though the receiver config is formatted as a list which isn't easily
editable in the hierarchy.
@simu simu force-pushed the alertmanager-config-prune-null branch from e957c9f to e13c156 Compare January 3, 2024 14:57
@simu simu merged commit c0d3e6b into master Jan 3, 2024
24 checks passed
@simu simu deleted the alertmanager-config-prune-null branch January 3, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants