Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expire silences after one day instead of one year #194

Merged
merged 3 commits into from
Mar 28, 2024
Merged

Conversation

haasad
Copy link
Member

@haasad haasad commented Mar 28, 2024

The cronjob renews the silence every 4 hours. I don't see any added benefits in creating silences with 1 year lifetime instead of one day.

However there is one major downside. If the silence functionality is used to suppress certain alerts temporarily, the silence stays active for 1 year after it's removed from the config hierarchy. To enable the alert again it, the silence has to be expired manually on all clusters.

Reducing this to one day is a compromise that allows to remove silences and ensure they're active again in a reasonable timeframe without having to manually expire all silences. Happy to discuss other values for the duration.

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

@haasad haasad added the change label Mar 28, 2024
@haasad haasad requested a review from a team as a code owner March 28, 2024 08:28
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Probably needs a make gen-golden-all

@haasad
Copy link
Member Author

haasad commented Mar 28, 2024

make gen-golden-all is still running 🐌 😄

@haasad haasad merged commit 735dbbb into master Mar 28, 2024
26 checks passed
@haasad haasad deleted the silence-duration branch March 28, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants