Fix OVNKubernetes alert rules for OpenShift 4.14 #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: no golden-tests changes because we don't actually have a test case that renders the OVNKubernetes alerts |
haasad
approved these changes
Apr 9, 2024
Should we add one? |
OpenShift 4.14 moved the OVNKubernetes control plane alerts (and we can't use the 4.13 alerts, because 4.14 makes significant changes to the OVNKubernetes architecture). Additionally 4.14 introduced gotemplate snippets in the OVNKubernetes alerts that we need to render. Since the files also contain gotemplate snippets which aren't valid Jinja2, we implement very simple rendering logic which uses `std.strReplace()` in the component.
simu
force-pushed
the
fix/ovnkubernetes-rules-4.14
branch
from
aed3691 to
3f430a7
Compare
First, I want to delete the 4.11 and 4.12 tests and configuration options, since we don't really need them anymore and the time to generate golden tests is getting out of hand for this component. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenShift 4.14 moved the OVNKubernetes control plane alerts (and we can't use the 4.13 alerts, because 4.14 makes significant changes to the OVNKubernetes architecture). Additionally 4.14 introduced gotemplate snippets in the OVNKubernetes alerts that we need to render.
Since the files also contain gotemplate snippets which aren't valid Jinja2, we implement very simple rendering logic which uses
std.strReplace()in the component.Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.