Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix service account kubebuilder annotations #159

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Fix service account kubebuilder annotations #159

merged 1 commit into from
Apr 25, 2023

Conversation

HappyTetrahedron
Copy link
Contributor

Summary

Due to copy-paste error, the annotations were giving the wrong permissions, causing things to not work.
...

Checklist

  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

@HappyTetrahedron HappyTetrahedron added the bug Something isn't working label Apr 25, 2023
@HappyTetrahedron HappyTetrahedron requested a review from a team as a code owner April 25, 2023 09:40
@HappyTetrahedron HappyTetrahedron force-pushed the fix/service-account-permissions branch from 5bc9423 to 4846336 Compare April 25, 2023 09:56
@HappyTetrahedron HappyTetrahedron merged commit 37403e6 into master Apr 25, 2023
@HappyTetrahedron HappyTetrahedron deleted the fix/service-account-permissions branch April 25, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastjan bastjan bastjan approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HappyTetrahedron @bastjan