Add access control to Organizations #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also rework abstraction for authorization to reduce code duplication
|
I may have gone overboard with the test. The actual code change is quite minimal |
ccremer
approved these changes
Jan 12, 2022
| @@ -2,6 +2,8 @@ package organization | |||
|
|
|||
There was a problem hiding this comment.
This file has gotten quite large. Maybe we can split it up based on the verb, if that makes sense?
e.g. organization_get_test.go, organization_update_test.go etc.
There was a problem hiding this comment.
Yes that file got a bit large. I'll try to split it up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds access control for organizations. This works by checking with the k8s API server if the action is allowed on a
organizations.rbac.appuio.ioresource. Watch and list only return objects that the user is also allowed to get.See https://kb.vshn.ch/appuio-cloud/references/architecture/control-api-org.html#_access_control
OrganizationMembers and RoleBindings will be handled in separate PRs
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.