Add User and OrganizationMembers Resources #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glrf
force-pushed
the
feat/users
branch
2 times, most recently
from
f383cba to
f95a269
Compare
ccremer
approved these changes
Jan 19, 2022
Co-authored-by: Chris <github.account@chrigel.net>
bastjan
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduces Users and OrganizationMembers according to https://kb.vshn.ch/appuio-cloud/references/architecture/control-api.html.
On Organization creation we will create an
OrganizationMembersresource containing a reference to the creating user.I introduced the same best effort abort logic to reduce the likelihood of us ending up in an inconsistent state. It's still possible if we e.g. crash during Organization creation, but that's our life without ACID and introducing something like sagas is IMO overkill.
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.