Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing RBAC permissions to the apiserver role #24

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Add missing RBAC permissions to the apiserver role #24

merged 1 commit into from
Jan 28, 2022

Conversation

glrf
Copy link
Contributor

@glrf glrf commented Jan 28, 2022 •
edited by ccremer
Loading

Checklist

  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

@glrf glrf added the bug Something isn't working label Jan 28, 2022
@glrf glrf self-assigned this Jan 28, 2022
@glrf glrf force-pushed the fix/apiserver-rbac branch from 4452f04 to e5822f4 Compare January 28, 2022 08:29
@glrf glrf requested a review from ccremer January 28, 2022 08:33
@ccremer ccremer changed the title Add missing permissions to the apiserver role Add missing RBAC permissions to the apiserver role Jan 28, 2022
ccremer
ccremer approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@ccremer ccremer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I think we also need RBAC permissions for the Zone and User types? Do we want to have it in a separate PR?

@glrf
Copy link
Contributor Author

glrf commented Jan 28, 2022

I mean the API server doesn't interact with these (yet), so they aren't really required in that role. Default permissions for API users are handled in separate PR.

@glrf glrf merged commit d0458e7 into master Jan 28, 2022
@glrf glrf deleted the fix/apiserver-rbac branch January 28, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccremer ccremer ccremer approved these changes

Assignees

@glrf glrf

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glrf @ccremer