Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove user id from reference #31

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Remove user id from reference #31

merged 1 commit into from
Feb 7, 2022

Conversation

glrf
Copy link
Contributor

@glrf glrf commented Feb 3, 2022

We decided to transition to only using the username and not the ID. It's the adapters job to resolve the username if necessary

Change documented in: appuio/appuio-io-docs#107

Checklist

  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

We decided to transition to only using the username and not the ID. It's
the adapters job to resolve the username if necessary
@glrf glrf force-pushed the breaking/remove-userid branch from 8d3dd8d to 878bdd3 Compare February 7, 2022 09:05
@glrf glrf added the breaking label Feb 7, 2022
@glrf glrf marked this pull request as ready for review February 7, 2022 09:08
@glrf glrf requested a review from bastjan February 7, 2022 09:09
@glrf glrf merged commit 9d29950 into master Feb 7, 2022
@glrf glrf deleted the breaking/remove-userid branch February 7, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants