Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organization.spec.billingEntityRef validation #87

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Organization.spec.billingEntityRef validation #87

merged 1 commit into from
Jan 10, 2023

Conversation

bastjan
Copy link
Contributor

@bastjan bastjan commented Jan 9, 2023 •
edited
Loading

Summary

Uses impersonation to check if a user can get a billing entity when referencing it in an Organization.

Checklist

  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

@bastjan bastjan force-pushed the validate-be-ref branch 2 times, most recently from e0d8f73 to 7fe7df9 Compare January 10, 2023 08:26
@bastjan bastjan added the enhancement New feature or request label Jan 10, 2023
@bastjan bastjan marked this pull request as ready for review January 10, 2023 13:57
@bastjan bastjan requested review from glrf and simu January 10, 2023 13:59
@bastjan bastjan changed the title BillingEntity validation draft with impersonation Organization.spec.billingEntityRef validation Jan 10, 2023
simu
simu approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't run the new logic myself, but I don't see any obvious errors in the implementation.

@bastjan bastjan merged commit 7e036f5 into master Jan 10, 2023
@bastjan bastjan deleted the validate-be-ref branch January 10, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glrf glrf glrf approved these changes

@simu simu simu approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bastjan @simu @glrf