Cache human readable billing entity name in Organization #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastjan
force-pushed
the
cache-billingentity-name
branch
from
21c4624 to
c738ad0
Compare
- Implement /status subresource handling for Organizations - Add controller writing this status
bastjan
force-pushed
the
cache-billingentity-name
branch
from
c738ad0 to
9db7b90
Compare
glrf
approved these changes
Jan 12, 2023
| var be billingv1.BillingEntity | ||
| err := r.Client.Get(ctx, client.ObjectKey{Name: org.Spec.BillingEntityRef}, &be) | ||
| if err != nil { | ||
| return ctrl.Result{}, err |
There was a problem hiding this comment.
Nitpick: I'm not sure if we want to log if the error is not found.
There was a problem hiding this comment.
Not found is an important error IMO since we validate that the entity exists on linking them.
There was a problem hiding this comment.
Hmm, maybe you're right. I'm not sure how helpful it really is if we log not found repleatedly if someone deletes the BE in Odoo, but you're right it's a relevant error.
There was a problem hiding this comment.
The good thing about returning an error is you get automated backoff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.