Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial S3 Store functionality #13

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Initial S3 Store functionality #13

merged 1 commit into from
Dec 21, 2023

Conversation

bastjan
Copy link
Contributor

@bastjan bastjan commented Dec 20, 2023

Summary

Currently only StoreToken is supported. This means tokens are not verified after upload.

Since we plan to only encrypt the secrets without storing a private key this should not be an issue for us.

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.

@bastjan bastjan added the enhancement New feature or request label Dec 20, 2023
@bastjan bastjan changed the title First S3 store draft S3 Store functionality Dec 21, 2023
@bastjan bastjan changed the title S3 Store functionality Initial S3 Store functionality Dec 21, 2023
@bastjan bastjan marked this pull request as ready for review December 21, 2023 10:51
@bastjan bastjan requested a review from a team as a code owner December 21, 2023 10:51
@bastjan bastjan merged commit 9f3ac94 into master Dec 21, 2023
3 checks passed
@bastjan bastjan deleted the s3-store branch December 21, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants