Skip to content
This repository has been archived by the owner on Jul 17, 2023. It is now read-only.

Implement node reconcile and drain metric #2

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Implement node reconcile and drain metric #2

merged 2 commits into from
Jan 23, 2023

Conversation

bastjan
Copy link
Contributor

@bastjan bastjan commented Jan 23, 2023 •
edited
Loading

This PR adds a controller reconciling nodes and updating their respective drain metrics.

@bastjan bastjan added the enhancement New feature or request label Jan 23, 2023
@bastjan bastjan requested review from a team and glrf January 23, 2023 12:20
simu
simu approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, comment regarding the kustomize template inline

config/manager/manager.yaml Show resolved Hide resolved
@bastjan bastjan force-pushed the implement-reconcile branch from 31120c5 to 1af0485 Compare January 23, 2023 12:48
@bastjan bastjan force-pushed the implement-reconcile branch from 1af0485 to f3f5fd6 Compare January 23, 2023 12:50
@bastjan bastjan merged commit a42c57a into master Jan 23, 2023
@bastjan bastjan deleted the implement-reconcile branch January 23, 2023 13:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@simu simu simu approved these changes

@glrf glrf Awaiting requested review from glrf

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastjan @simu