Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application of floating UI helpers within dropdown component #349

Merged
merged 40 commits into from
Jan 9, 2023
Merged

Application of floating UI helpers within dropdown component #349

merged 40 commits into from
Jan 9, 2023

Conversation

brenner-company
Copy link
Collaborator

@brenner-company brenner-company commented Dec 7, 2022 •
edited by Windvis
Loading

The application of the newly created AuFloatingUi component to the AuDropdown component.

See #333 for additional information.

⚠️ PR #344 must be merged before finalising this one (as this is based on that specific branch)! Also the base for branch needs to be switched to development before merging.

Closes #333

@brenner-company
Add necessary packages
8cca2d3
@brenner-company
Add floating-ui modifier
3ff840b
@brenner-company
Add floating-ui component
885d843
@brenner-company
Add floating-ui story (Storybook)
b0b7b56
@brenner-company
Add exemplary styling for floating-ui component
d431fe7
@brenner-company
Fix static floater offset & unused variable
8659042
@brenner-company
Reorder middleware options
ddd25f2
@brenner-company
Add middleware control & enable default values
73fb754
@brenner-company
Remove middleware argument & restructure middleware settings (bugfix)
9d70b06
@brenner-company
Fix floating-ui story (missing argument)
d13af70
@brenner-company
Add test coverage for floating-ui modifier & component
1119b6d
@brenner-company
Relocate example scroller/floater structure & styling to dummy component
ac5f429
@brenner-company
Disable linting error for a moment (before extending functionality)
33b7bf6
@brenner-company
Merge branch 'development' into feature/addition-of-floating-ui-helpers
1edb52f
@brenner-company
Add functionality for the example scroller component
86f7306
@brenner-company
Merge branch 'development' into feature/addition-of-floating-ui-helpers
91825a1
@brenner-company
Enable use of both negative & positive offset values for the arrow
1438f26
@brenner-company
Adjust dropdown component (for floating-ui usage)
edec58f
brenner-company
brenner-company commented Dec 8, 2022
View reviewed changes
testem.js Outdated Show resolved Hide resolved
@brenner-company brenner-company marked this pull request as ready for review December 8, 2022 13:30
@brenner-company brenner-company removed the request for review from Dietr December 13, 2022 10:26
@brenner-company brenner-company mentioned this pull request Jan 4, 2023
Merged
3 tasks
@brenner-company
Remove component version of floating-ui helper
8ef07c7
@brenner-company
Remove floating-ui Storybook story
8c7390c
@brenner-company
Delete re-export of floating-ui modifier
827fb07
@brenner-company
Move floating-ui modifier to private folder & rename identifier
062f607
@brenner-company
Adjust floating-ui modifier assertions
170fbab
@brenner-company
Move floating-ui modifier test to private folder, rename identifier &…
9d5ced4 
… rework import
@brenner-company
Remove dummy floater styling (not needed anymore)
740b87e
@brenner-company
Merge branch 'feature/addition-of-floating-ui-helpers' into feature/d…
33d09a6 
…ynamic-display-of-menu-within-dropdown
@brenner-company
Remove example scroller component & styling
8842d20
@brenner-company
Merge branch 'feature/addition-of-floating-ui-helpers' into feature/d…
38f6213 
…ynamic-display-of-menu-within-dropdown
@brenner-company
Adjust integration of floating-ui within dropdown component
4fe5420
Base automatically changed from feature/addition-of-floating-ui-helpers to development January 5, 2023 09:46
@Windvis Windvis added the enhancement Used when the PR adds a new feature or enhancement. label Jan 5, 2023
@brenner-company
Copy link
Collaborator Author

@Windvis I think this one is good to go 👍 Just let me know if you have anymore question or remarks.

Windvis
Windvis reviewed Jan 6, 2023
View reviewed changes
addon/components/au-dropdown.hbs Outdated Show resolved Hide resolved
addon/components/au-dropdown.hbs Outdated Show resolved Hide resolved
addon/components/au-dropdown.hbs Outdated Show resolved Hide resolved
addon/components/au-dropdown.js Show resolved Hide resolved
@Windvis
Copy link
Contributor

Windvis commented Jan 6, 2023

(The failing test is unrelated to these changes. I wrote a flaky test it seems, will fix in dev, but you can ignore that)

@Windvis Windvis merged commit 2b6e6c8 into development Jan 9, 2023
@Windvis Windvis deleted the feature/dynamic-display-of-menu-within-dropdown branch January 9, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Windvis Windvis Windvis approved these changes

Assignees
No one assigned
Labels
enhancement Used when the PR adds a new feature or enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More dynamic display of menu element within dropdown component
2 participants
@brenner-company @Windvis