Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl.exe is not on PATH #1426

Closed
FeodorFitsner opened this issue Mar 21, 2017 · 11 comments
Closed

curl.exe is not on PATH #1426

FeodorFitsner opened this issue Mar 21, 2017 · 11 comments
Labels
Milestone

Comments

@FeodorFitsner
Copy link
Member

FeodorFitsner commented Mar 21, 2017

Previous versions of Git had curl.exe in C:\Program Files\Git\usr\bin folder which is added in PATH on build workers. The main reason it was on PATH was ssh.exe utility Git (and Mercurial) required to fetch repo via SSH.

Now, curl.exe has gone from C:\Program Files\Git\usr\bin and left in C:\Program Files\Git\mingw64\bin only. To fix the build add this to your appveyor.yml:

install:
- set PATH=C:\Program Files\Git\mingw64\bin;%PATH%

Alternatively, CURL can be installed via Chocolatey with choco install curl command or used from other locations such as MinGW, Cygwin and MSYS: https://www.appveyor.com/docs/build-environment/#mingw-msys-cygwin, for example:

  • C:\msys64\usr\bin
  • C:\cygwin\bin

We are not yet completely sure whether we should explicitly add C:\Program Files\Git\mingw64\bin folder into PATH on build workers or not - there is always a risk of causing another conflict. Less stuff on PATH is better.

@FeodorFitsner FeodorFitsner added this to the 19-Mar-2017 milestone Mar 21, 2017
@jakirkham
Copy link

Would it be possible to copy it back? Even when I say it, I know it sounds pretty hacky. Just thinking of the best way to fix things quickly given this change.

@FeodorFitsner
Copy link
Member Author

Yes, we are going to fix that by adding C:\Program Files\Git\mingw64\bin to PATH.

@jakirkham
Copy link

Out of curiosity is there anything else of note in that directory?

@FeodorFitsner
Copy link
Member Author

@jakirkham
Copy link

Thanks. There are a few things that could clash. Though we make sure are stuff is searched first. So I don't think it will be an issue.

@FeodorFitsner
Copy link
Member Author

Does curl.exe depend on some other libs/dlls or it's standalone exe? Maybe we could just copy it somewhere under C:\Tools and add that folder into PATH?

@jakirkham
Copy link

From my notes, it could be linked to zlib.

@Diggsey
Copy link

Diggsey commented Mar 21, 2017

This is really unhelpful! Can't you make updates to the system images be manual, so that we can deal with changes at a convenient time?

@avh4
Copy link

avh4 commented Mar 21, 2017

Thanks for the quick updates! The suggested workaround had me up and running again in a few minutes.

@IlyaFinkelshteyn
Copy link
Contributor

@Diggsey sorry for the trouble. We need to make this experience better and filed #1430

@FeodorFitsner
Copy link
Member Author

We're going to have curl installed on build workers and added to PATH: #1431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants