Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile #6020

Closed
wants to merge 1 commit into from
Closed

Conversation

Rithwik0480
Copy link

Executables

RUN chmod +x -R /usr/local/bin made this change in dockerfile so that every file in /usr/local/bin will get the exec permission.

What does this PR do?

RUN chmod +x -R /usr/local/bin made this change in dockerfile so that every file in /usr/local/bin will get the exec permission.

Test Plan

I build the docker image locally and tested.

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

# Executables
`RUN chmod +x -R /usr/local/bin`  made this change in dockerfile so that every file in `/usr/local/bin` will get the exec permission.
@Rithwik0480
Copy link
Author

@eldadfux The docker file is working fine with the changes I made. The error in workflow was related to time no errors thrown up other than that.

@abnegate
Copy link
Contributor

Hey @Rithwik0480, thanks for the PR! While your way in certainly less verbose and easier to maintain, it doesn't fit with our principle of security by default to give everything in /usr/local/bin execute access when we have no control over the binaries already in there.

@abnegate abnegate closed this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants