Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Improve worker logging #7192

Merged
merged 4 commits into from
Jan 11, 2024
Merged

Feat: Improve worker logging #7192

merged 4 commits into from
Jan 11, 2024

Conversation

Meldiron
Copy link
Contributor

@Meldiron Meldiron commented Nov 22, 2023 •
edited
Loading

What does this PR do?

Improves details of Sentry logs, allowing better filtering.

Test Plan

  • Manual QA
    ✅ Builds
    ✅ Certificates
    ✅ Databases
    ✅ Deletes
    ✅ Functions
    ✅ Mails
    ✅ Messaging
    ♻️ Migration
    ✅ Webhooks

Related PRs and Issues

x

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@github-actions github-actions bot mentioned this pull request Dec 1, 2023
Closed
@Meldiron Meldiron changed the base branch from 1.4.x to 1.5.x January 2, 2024 11:09
@Meldiron
Copy link
Contributor Author

Meldiron commented Jan 2, 2024 •
edited
Loading

QA:

CleanShot 2024-01-02 at 13 30 08@2x

CleanShot 2024-01-02 at 13 36 27@2x

CleanShot 2024-01-02 at 13 43 05@2x

CleanShot 2024-01-02 at 13 41 55@2x

CleanShot 2024-01-02 at 13 49 28@2x

CleanShot 2024-01-02 at 13 49 25@2x

CleanShot 2024-01-02 at 13 55 44@2x

CleanShot 2024-01-02 at 13 55 29@2x

shimonewman
shimonewman approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@shimonewman shimonewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christyjacob4 christyjacob4 merged commit d87eb14 into 1.5.x Jan 11, 2024
21 checks passed
@christyjacob4 christyjacob4 deleted the feat-improve-logging branch January 11, 2024 14:35
@github-actions github-actions bot mentioned this pull request Feb 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shimonewman shimonewman shimonewman approved these changes

@christyjacob4 christyjacob4 christyjacob4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Meldiron @christyjacob4 @shimonewman