Add CLI as a function deployment type #8215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byawitz
added
the
product / functions
PineappleIOnic
approved these changes
May 30, 2024
stnguyen90
reviewed
Jun 5, 2024
| @@ -1163,6 +1163,7 @@ | |||
| } | |||
|
|
|||
| $activate = (bool) filter_var($activate, FILTER_VALIDATE_BOOLEAN); | |||
| $type = $request->getHeader('x-sdk-language') === 'cli' ? 'cli' : 'manual'; | |||
There was a problem hiding this comment.
Any chance we can update a test case to check for this?
There was a problem hiding this comment.
The failing test is not relevant
christyjacob4
approved these changes
Jun 25, 2024
stnguyen90
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Set the function deployment type as
cliwhenx-sdk-languagematches thecli. This will make it possible to filter function deployments by CLI.Test Plan
Tested against local
1.5.5instanceRelated
Checklist