Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new push message parameters #9060

Open
wants to merge 25 commits into
base: 1.6.x
Choose a base branch
from
Open

Add new push message parameters #9060

wants to merge 25 commits into from

Conversation

abnegate
Copy link
Contributor

@abnegate abnegate commented Dec 3, 2024 •
edited
Loading

What does this PR do?

Adds new push flags:

  • contentAvailable: (iOS only) when set, notifications will wake up the app in the background to deliver the notification
  • critical: (iOS only) when set, tries to mark notification as "critical" to ignore silent/do not disturb settings. Requires app to be granted the critical notification entitlement by Apple.
  • priority: Let's you set either normal or high priority for notifications. Normal priority will deliver at the most convenient time depending on multiple factors

Fixes: #8854

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
pyc 3.12.7-r0 CVE-2024-12254 HIGH
python3 3.12.7-r0 CVE-2024-12254 HIGH
python3-pyc 3.12.7-r0 CVE-2024-12254 HIGH
python3-pycache-pyc0 3.12.7-r0 CVE-2024-12254 HIGH
golang.org/x/crypto v0.26.0 CVE-2024-45337 CRITICAL
golang.org/x/net v0.28.0 CVE-2024-45338 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 3, 2024 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/appwrite/appwrite/@appwrite.io/console@9060

commit: 4ce919c

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

✨ Benchmark results

  • Requests per second: 1,061
  • Requests with 200 status code: 190,946
  • P99 latency: 0.174377191

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,061 1,688
200 190,946 303,951
P99 0.174377191 0.071073408

@abnegate abnegate changed the base branch from main to 1.6.x December 3, 2024 07:46
@stnguyen90 stnguyen90 mentioned this pull request Dec 4, 2024
Merged
@stnguyen90 stnguyen90 linked an issue Dec 4, 2024 that may be closed by this pull request
🐛 Bug Report: Push Notification for iOS badge is string, but should be number #8854
Open
2 tasks
stnguyen90
stnguyen90 reviewed Dec 4, 2024
View reviewed changes
app/controllers/api/messaging.php Outdated Show resolved Hide resolved
app/controllers/api/messaging.php Outdated Show resolved Hide resolved
@abnegate abnegate requested a review from stnguyen90 December 5, 2024 07:25
@abnegate @lohanidamodar
Update src/Appwrite/Platform/Workers/Messaging.php
526f54c 
Co-authored-by: Damodar Lohani <lohanidamodar@users.noreply.github.com>
lohanidamodar
lohanidamodar reviewed Dec 5, 2024
View reviewed changes
Copy link
Member

@lohanidamodar lohanidamodar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. let's release the library first and upgrade.

@abnegate
Copy link
Contributor Author

abnegate commented Dec 9, 2024

Blocked by Apple developer account needed to properly test background notifications

@abnegate abnegate changed the title Feat apns content available Add new push message parameters Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stnguyen90 stnguyen90 stnguyen90 approved these changes

@lohanidamodar lohanidamodar Awaiting requested review from lohanidamodar

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
1.6 Release
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Push Notification for iOS badge is string, but should be number
3 participants
@abnegate @stnguyen90 @lohanidamodar