Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix arm build and api key #7

Merged
merged 4 commits into from
Aug 20, 2023
Merged

Fix arm build and api key #7

merged 4 commits into from
Aug 20, 2023

Conversation

stnguyen90
Copy link
Contributor

@stnguyen90 stnguyen90 commented Aug 18, 2023 •
edited
Loading

What does this PR do?

  • Prevent node_modules from being copied to docker
  • Bump faiss-node to fix arm build error
  • Explicitly pass the API key due to Update .env var #6
  • Enable arm releases since they should work again

Test Plan

Manual

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Yes

@stnguyen90
Explicitly pass the API key
7445efb 
Since the API key was named, it isn't automatically picked up so it must
explicitly be passed in.
@stnguyen90
Bump faiss-node to fix arm build error
f116858
@stnguyen90
Prevent node_modules from being copied to docker
e2f0c51
@stnguyen90 stnguyen90 requested a review from TGlide August 18, 2023 20:38
@Meldiron Meldiron mentioned this pull request Aug 19, 2023
Closed
1 task
@Meldiron Meldiron merged commit 8b027a4 into main Aug 20, 2023
@Meldiron Meldiron deleted the fix-arm-build-and-api-key branch August 20, 2023 07:41
This was referenced Sep 1, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TGlide TGlide TGlide approved these changes

@Meldiron Meldiron Meldiron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stnguyen90 @Meldiron @TGlide