Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: Getting not found when hovering over users/verified custom permission #1448

Open
2 tasks done
dokgu opened this issue Jul 30, 2023 · 6 comments
Open
2 tasks done
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@dokgu
Copy link

dokgu commented Jul 30, 2023

👟 Reproduction steps

On your collection's settings page, click + Add role under Permissions and select Custom permission and enter users/verified as mentioned here.

Once you've added that, hover over the text and it says "Not found."

permissions

👍 Expected behavior

Not really sure what I expect to show in there but "Not found" seems misleading.

👎 Actual Behavior

Even if the value is a valid permission string, it shows as Not Found.

🎲 Appwrite version

Version 1.3.x

💻 Operating system

Linux

🧱 Your Environment

No response

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

@dokgu dokgu added the bug Something isn't working label Jul 30, 2023
@Haimantika
Copy link

Thanks @dokgu for raising this issue. We will be looking into this, however what we advise is to go by the route suggested by Vincent here - appwrite/appwrite#5036 (reply in thread)

@Haimantika Haimantika self-assigned this Aug 3, 2023
@stnguyen90 stnguyen90 added the good first issue Good for newcomers label Aug 7, 2023
@stnguyen90
Copy link
Contributor

I think we need an additional case here:

{#if role === 'users'}
<div>Users</div>
{:else if role === 'guests'}
<div>Guests</div>
{:else if role === 'any'}
<div>Any</div>
{:else}
<div

@Prithvi101
Copy link

can you assigne this issue to me

@Haimantika
Copy link

can you assigne this issue to me

I have already raised a PR here - #494

Feel free to add your suggestion

@stnguyen90 stnguyen90 linked a pull request Oct 10, 2023 that will close this issue
@subhanahujha007
Copy link

/attempt:#5912

@stnguyen90
Copy link
Contributor

@Prithvi101, @subhanahujha007, are you still interested in working on this?

@eldadfux eldadfux transferred this issue from appwrite/appwrite Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants