Added custom role option for verified users #494
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -38,6 +38,8 @@ | |||
| <div>Guests</div> | |||
| {:else if role === 'any'} | |||
| <div>Any</div> | |||
| {:else if !role.startsWith('user') && !role.startsWith('team') } | |||
| <div>Users/Verfified</div> | |||
There was a problem hiding this comment.
This should probably be {role} instead of Users/Verfified since we want to accept whatever the user sets as custom role
There was a problem hiding this comment.
This should probably be
{role}instead ofUsers/Verfifiedsince we want to accept whatever the user sets as custom role
Yeah, makes sense. Made changes
| @@ -38,6 +38,8 @@ | |||
| <div>Guests</div> | |||
| {:else if role === 'any'} | |||
| <div>Any</div> | |||
| {:else if !role.startsWith('user') && !role.startsWith('team') } | |||
There was a problem hiding this comment.
I don't think this is the right condition 🧐
There was a problem hiding this comment.
True... if the custom role starts with users or teams it doesn't work
There was a problem hiding this comment.
Maybe a {:else if role.startsWith('user') || role.startsWith('team') } can solve?
There was a problem hiding this comment.
Maybe a {:else if role.startsWith('user') || role.startsWith('team') } can solve?
sure if that covers all the cases.
|
Also, looks like the linter fails. |
| {:else if role.startsWith('user') || role.startsWith('team')} | ||
| <div>{role}</div> |
There was a problem hiding this comment.
I think this would change the behavior of if you put a specific team/user, right? This wouldn't work anymore, right?
What does this PR do?
Adds a condition for verified users
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes