Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MFA flow #1082

Merged
merged 12 commits into from
May 16, 2024
Merged

Update MFA flow #1082

merged 12 commits into from
May 16, 2024

Conversation

stnguyen90
Copy link
Contributor

What does this PR do?

  • hide MFA methods and recovery if MFA is disabled
  • only show MFA recovery codes after a factor is enabled
  • allow using other methods to regenerate recovery codes

Test Plan

Manual

Related PRs and Issues

Parent:

Have you read the Contributing Guidelines on issues?

Yes

@vercel Vercel
Copy link

vercel bot commented May 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console-billing ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 6:18pm
console-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 6:18pm
console-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 6:18pm
console-preview-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 6:18pm

@stnguyen90 stnguyen90 marked this pull request as ready for review May 15, 2024 16:20
Base automatically changed from chore-bump-pink to main May 15, 2024 17:19
@stnguyen90 stnguyen90 mentioned this pull request May 16, 2024
Closed
2 tasks
@stnguyen90 stnguyen90 self-assigned this May 16, 2024
stnguyen90 added 12 commits May 16, 2024 11:11
@stnguyen90
feat(auth): show notification when MFA is enabled/disabled
1460ebd
@stnguyen90
feat(auth): rename recovery codes file download to appwrite-backups.txt
fb01768 
This helps clarify it's for appwrite.
@stnguyen90
feat(auth): only show "Successfully logged in." if MFA not required
184f2ec 
It's weird to show the "Successfully logged in." message when the user
is prompted for verification because they aren't fully logged in yet.
@stnguyen90
fix(auth): fix event tracking on login
3eb6607
@stnguyen90
refactor(auth): move mfa challenge to its own component
95096ea 
This will allow us to reuse the component in other places.
@stnguyen90
feat(auth): hide MFA methods and recovery if MFA is disabled
be527f8
@stnguyen90
feat(auth): only show MFA recovery codes after a factor is enabled
264ce68
@stnguyen90
fix(elements): allow InputDigits to auto submit again
3e7eb80 
If a user inputs an incorrect code, deletes what they put, and then
enters a different code, the InputDigits component should auto submit
again if autoSubmit is true.
@stnguyen90
fix(elements): fix InputDigits undefined element error
fdb9795 
If the InputDigits component is removed, the element will be undefined
but the onValueChange callback may still trigger. This change ensures
an element is found to prevent calling querySelector on undefined.
@stnguyen90
feat(auth): allow using other methods to regenerate recovery codes
ce1ffb6
@stnguyen90
fix(auth): await auth to prevent console.variables() from throwing
72f1563
@stnguyen90
fix(auth): remove margins on account MFA text buttons on mobile
0b9172e
@stnguyen90 stnguyen90 merged commit 0af1af4 into main May 16, 2024
7 checks passed
@stnguyen90 stnguyen90 deleted the fix-mfa-flow branch May 16, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenparnasa chenparnasa chenparnasa approved these changes

@TorstenDittmann TorstenDittmann TorstenDittmann approved these changes

Assignees

@stnguyen90 stnguyen90

Labels
None yet
Projects
1.5 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stnguyen90 @TorstenDittmann @chenparnasa