Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bad modals on safari #1531

Merged
merged 4 commits into from
Nov 21, 2024
Merged

fix: bad modals on safari #1531

merged 4 commits into from
Nov 21, 2024

Conversation

TorstenDittmann
Copy link
Contributor

@TorstenDittmann TorstenDittmann commented Nov 21, 2024 •
edited
Loading

What does this PR do?

  • looks like safari doesnt like user input like autofocus and doesnt initially place the dialog in the center

fixes:

Have you read the Contributing Guidelines on issues?

✅

@ArmanNik ArmanNik merged commit 9f754d3 into main Nov 21, 2024
2 checks passed
@ernstmul ernstmul deleted the fix-edit-attribute-modal-safari branch January 6, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArmanNik ArmanNik ArmanNik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TorstenDittmann @ArmanNik