-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sum stats instead of last #172
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -89,14 +89,14 @@ | |||
|
|||
<div class="grid-item-1-end-start"> | |||
<div class="heading-level-4"> | |||
{format(last($usage.documents).value)} | |||
{format(total($usage.documents))} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the one for documents should be fine 👍🏻 they dont need any change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think only executions are different
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All these should be summed, as all these are now using time-series data, before we got sum from database and data already had the sum, now it's not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that after usage refactor the is no more aggregation and we ONLY have time series data. So we should be summing everything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, not the best solution since we don't have real total, just total in time period. But its a patch until usage container can properly sum.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
What does this PR do?
Instead of showing last 1H/1D stat in overview, we sum all results.
Test Plan
Related PRs and Issues
x
Have you read the Contributing Guidelines on issues?
Yes