Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 5295 code component style fix #377

Merged

Conversation

kabhamo
Copy link
Contributor

@kabhamo kabhamo commented Apr 2, 2023

What does this PR do?

The fix is simple, adjust the padding-top style, so the clipboard icon has more space.
I have ensured that the code space and all the elements have flexible sizes relevant to the screen size.
see the picture below

Screenshot 2023-03-30 at 2 07 01

Screenshot 2023-03-30 at 2 06 50

Test Plan

Run the console dashboard on the localhost
create new project
create new platform
click next till you reach the "Let's coding" step

Related PRs and Issues

appwrite/appwrite#5295

Have you read the Contributing Guidelines on issues?

Yes

@vercel
Copy link

vercel bot commented Apr 2, 2023

@kabhamo is attempting to deploy a commit to the appwrite Team on Vercel.

A member of the Team first needs to authorize it.

@stnguyen90 stnguyen90 requested a review from ArmanNik April 25, 2023 19:05
@stnguyen90 stnguyen90 linked an issue Apr 25, 2023 that may be closed by this pull request
2 tasks
@ArmanNik
Copy link
Member

@kabhamo instead of using padding-top let's use padding-block-start :)
Also, simply removing the padding property has pretty much the same effect 🤔 @chenparnasa was the tag overlap ping the code intended?

@kabhamo
Copy link
Contributor Author

kabhamo commented Apr 26, 2023

Because when decreasing the screen size it will crash the style.
However I will test the css property u mentioned ASAP.

@kabhamo
Copy link
Contributor Author

kabhamo commented May 2, 2023

@ArmanNik, I have changed the property to padding-block-start.
It works as needed, please review the code and tell me if anything is needed.

@chenparnasa
Copy link
Contributor

@ArmanNik The behavior now is similar to the old code snippets we are using (in the docs for example). We might iterate this component in the future, but for now, we can increase the padding so the code and tag won't overlap

Copy link
Contributor

@TorstenDittmann TorstenDittmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you fix the linter issues with npm run format 🙏🏻

@stnguyen90
Copy link
Contributor

@kabhamo, would you please fix the linting errors?

@kabhamo
Copy link
Contributor Author

kabhamo commented Jul 18, 2023

@stnguyen90 yeah sure i will do it

@kabhamo kabhamo requested a review from TorstenDittmann July 19, 2023 17:24
@kabhamo
Copy link
Contributor Author

kabhamo commented Jul 19, 2023

@stnguyen90 waiting for a review

@vercel
Copy link

vercel bot commented Aug 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 11, 2023 0:53am
console-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 11, 2023 0:53am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: unnecessary scrollbars
6 participants