-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 5295 code component style fix #377
Fix 5295 code component style fix #377
Conversation
…-code-component-style-fix
@kabhamo is attempting to deploy a commit to the appwrite Team on Vercel. A member of the Team first needs to authorize it. |
@kabhamo instead of using |
Because when decreasing the screen size it will crash the style. |
@ArmanNik, I have changed the property to |
@ArmanNik The behavior now is similar to the old code snippets we are using (in the docs for example). We might iterate this component in the future, but for now, we can increase the padding so the code and tag won't overlap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you fix the linter issues with npm run format
🙏🏻
@kabhamo, would you please fix the linting errors? |
@stnguyen90 yeah sure i will do it |
@stnguyen90 waiting for a review |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
What does this PR do?
The fix is simple, adjust the
padding-top
style, so the clipboard icon has more space.I have ensured that the code space and all the elements have flexible sizes relevant to the screen size.
see the picture below
Test Plan
Run the console dashboard on the localhost
create new project
create new platform
click next till you reach the "Let's coding" step
Related PRs and Issues
appwrite/appwrite#5295
Have you read the Contributing Guidelines on issues?
Yes