Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Deleting Account #447

Closed
wants to merge 1 commit into from

Conversation

stnguyen90
Copy link
Contributor

@stnguyen90 stnguyen90 commented May 18, 2023

What does this PR do?

Console accounts are not deleted, so a user won't be able to re-create their account after "deleting" it.

Test Plan

Manual:

image image image

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Yes

@vercel
Copy link

vercel bot commented May 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2023 6:41pm
console-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2023 6:41pm

Copy link
Member

@ArmanNik ArmanNik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stnguyen90 let's also clear all the locally stored data (both local and session storage), otherwise the user won't be able to login with another account

I would also suggest adding a checkbox for confirmation the same way we do it for documents with relationships 😄

@stnguyen90
Copy link
Contributor Author

@ArmanNik

let's also clear all the locally stored data (both local and session storage), otherwise the user won't be able to login with another account

Yep! I plan on submitting a separate PR for that today.

I would also suggest adding a checkbox for confirmation the same way we do it for documents with relationships

I want to make sure we can roll this out to cloud...are there styling issues with checkboxes for the version cloud is on?

image

@stnguyen90 stnguyen90 requested a review from ArmanNik May 19, 2023 15:02
@stnguyen90 stnguyen90 marked this pull request as ready for review May 19, 2023 19:21
@ArmanNik
Copy link
Member

There are still issues with the checkbox style on Cloud... the solution is to update Cloud to the latest version of Appwrite 🙃

Console accounts are not actually deleted so a user won't be able to
re-create their account after "deleting" it.
@eldadfux
Copy link
Member

eldadfux commented Aug 1, 2023

Not sure about this feature, let's wait. It might be better to just allow deletion and trust backups for any abusive play.

@stnguyen90 stnguyen90 closed this Aug 2, 2023
@stnguyen90 stnguyen90 deleted the feat-clarify-delete-account branch August 2, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants