Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#430): Change success message to 'Creating Index' for better user… #486

Merged

Conversation

Chaitanya-Upadhye
Copy link
Contributor

@Chaitanya-Upadhye Chaitanya-Upadhye commented Aug 1, 2023

… understanding

What does this PR do?

This PR addresses issue #430. The 'Index has been created' message has been updated to 'Creating Index' to provide a more accurate description of the indexing operation's status.

Test Plan

Manual

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Yes

@vercel
Copy link

vercel bot commented Aug 1, 2023

@Chaitanya-Upadhye is attempting to deploy a commit to the appwrite Team on Vercel.

A member of the Team first needs to authorize it.

@ArmanNik
Copy link
Member

ArmanNik commented Aug 8, 2023

I think the message it's ok as it is WDYT @chenparnasa ?

@chenparnasa
Copy link
Contributor

I agree @ArmanNik, we should be consistent with the rest of the creation alerts :)

@ArmanNik
Copy link
Member

ArmanNik commented Aug 8, 2023

cc: @stnguyen90

@stnguyen90 stnguyen90 self-requested a review August 8, 2023 15:38
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This matches what we decided to do for retrying a build:

addNotification({
type: 'success',
message: `Retrying build`
});

@eldadfux eldadfux merged commit a8ec722 into appwrite:main Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants