Filtering #490
Merged
Filtering #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ArmanNik
reviewed
Aug 8, 2023
Comment on lines
112
to
122
| <style lang="scss"> | ||
| .cool-grid { | ||
| display: grid; | ||
| grid-template-columns: 1fr 1fr; | ||
| gap: 2rem; | ||
|
|
||
| > :global(h2) { | ||
| grid-column: span 2; | ||
| } | ||
| } | ||
| </style> |
There was a problem hiding this comment.
@TGlide since we use this template so much we should probably add it to Pink
There was a problem hiding this comment.
You mean the grid-template columns?
...nsole/project-[project]/databases/database-[database]/collection-[collection]/filters.svelte
Outdated
Show resolved
Hide resolved
Comment on lines
300
to
307
| hr { | ||
| height: 1px; | ||
| width: calc(100% + 2rem); | ||
| background-color: hsl(var(--color-border)); | ||
|
|
||
| margin-block-start: 1rem; | ||
| margin-inline: -1rem; | ||
| } |
There was a problem hiding this comment.
I think we already have dividers in pink
There was a problem hiding this comment.
Didn't find them on pink.appwrite.io 🤔
There was a problem hiding this comment.
Then we probably need to add them 😆 but I'm sure they are in the code
|
|
||
| <p class="u-text-center u-margin-block-start-24"> | ||
| Signed in as test@test.com <button |
There was a problem hiding this comment.
Does test@test.com need to stay here?
There was a problem hiding this comment.
@PineappleIOnic does the firebase report return a username/email?
...tes/console/project-[project]/databases/database-[database]/collection-[collection]/+page.ts
Outdated
Show resolved
Hide resolved
| export const load: PageLoad = async ({ params, depends, url, route }) => { | ||
| depends(Dependencies.DOCUMENTS); | ||
| const page = getPage(url); | ||
| const limit = getLimit(url, route, PAGE_LIMIT); | ||
| const view = getView(url, route, View.Grid); | ||
| const offset = pageToOffset(page, limit); | ||
|
|
||
| const queries = url.searchParams.get('query'); | ||
| const parsedQueries = queryParamToMap(queries || '[]'); | ||
| console.log(parsedQueries); |
christyjacob4
requested changes
Aug 8, 2023
…ase]/collection-[collection]/+page.ts Co-authored-by: Christy Jacob <christyjacob4@gmail.com>
christyjacob4
approved these changes
Aug 9, 2023
This was referenced Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.