Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add messaging providers route #602

Merged
merged 9 commits into from
Jan 2, 2024
Merged

Add messaging providers route #602

merged 9 commits into from
Jan 2, 2024

Conversation

stnguyen90
Copy link
Contributor

@stnguyen90 stnguyen90 commented Oct 24, 2023 •
edited
Loading

What does this PR do?

Add messaging providers route

Test Plan

TBD

Related PRs and Issues

Parent:

Children:

Have you read the Contributing Guidelines on issues?

Yes

@stnguyen90 stnguyen90 marked this pull request as draft October 24, 2023 23:57
@vercel
Copy link

vercel bot commented Oct 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2024 2:53pm
console-cloud 🛑 Canceled (Inspect) Jan 2, 2024 2:53pm
console-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2024 2:53pm
console-preview-cloud 🛑 Canceled (Inspect) Jan 2, 2024 2:53pm

@stnguyen90 stnguyen90 mentioned this pull request Oct 26, 2023
Merged
@stnguyen90 stnguyen90 changed the base branch from main to feat-messaging-overview October 26, 2023 00:15
stnguyen90
stnguyen90 commented Oct 26, 2023
View reviewed changes
src/routes/console/project-[project]/messaging/providers/store.ts Outdated
{ id: 'status', title: 'Status', show: true }
]);

export const providers = {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TorstenDittmann, what do you think about having this JSON for the wizard for all providers. I wanted to try and minimize the number of places you'd need to go if we add a messaging provider in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Torsten: for now, let's continue with this.

stnguyen90
stnguyen90 commented Oct 26, 2023
View reviewed changes
src/routes/console/project-[project]/messaging/providers/create.svelte
try {
let response = { $id: '', name: '' };
const providerId = $providerParams[$provider].providerId || ID.unique();
switch ($provider) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TorstenDittmann, this is going to be long and annoying because there's a different method for each provider. Any thoughts on how to improve this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Torsten: for now, let's go with this.

stnguyen90
stnguyen90 commented Oct 26, 2023
View reviewed changes
src/routes/console/project-[project]/messaging/providers/wizard/store.ts Outdated
Comment on lines 28 to 103
export const providerParams = writable<{ mailgun: Partial<MailgunProviderParams> }>({
mailgun: null
});
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TorstenDittmann, I wanted to do this to make the create/update part easier, but do you think it's not worth it and I should just have a writable for each provider?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Torsten: for now, let's go with this.

@TorstenDittmann TorstenDittmann merged commit bc9c899 into feat-messaging-overview Jan 2, 2024
1 of 4 checks passed
@TorstenDittmann TorstenDittmann deleted the feat-messaging-providers branch January 2, 2024 14:47
@github-actions github-actions bot mentioned this pull request Feb 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TorstenDittmann TorstenDittmann TorstenDittmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stnguyen90 @TorstenDittmann