Fix aria label on Empty component #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
TGlide
reviewed
Oct 30, 2023
src/lib/components/empty.svelte
Outdated
| @@ -27,7 +27,7 @@ | |||
| type="button" | |||
| on:click|preventDefault | |||
| on:click={track} | |||
| aria-label={`create {target}`}> | |||
| aria-label={`create ${target}`}> | |||
There was a problem hiding this comment.
Svelte has a more straightforward syntax for interpolating on HTML attributes
Suggested change
| aria-label={`create ${target}`}> | |
| aria-label="create {target}"> |
There was a problem hiding this comment.
thanks for the tip! I've updated the attribute as suggested.
The string wasn't interpolating target.
stnguyen90
force-pushed
the
fix-empty-component
branch
from
c8802be to
32a04dd
Compare
TGlide
approved these changes
Oct 31, 2023
TorstenDittmann
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The string wasn't interpolating target.
Test Plan
Manual
Related PRs and Issues
None
Have you read the Contributing Guidelines on issues?
Yes