Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: nextjs server-side-rendering #28

Merged
merged 8 commits into from
May 31, 2024
Merged

Conversation

loks0n
Copy link
Member

@loks0n loks0n commented Jan 25, 2024

No description provided.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have top level be:

nextjs-examples
react-examples

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☝🏼 is a good idea. Or at the very least make the folder match the others and use the same path as the website like example-nextjs-ssr-auth.

Copy link
Member Author

@loks0n loks0n May 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the benefit of the word example here, the whole repo is examples

nextjs/server-side-rendering/route.ts Outdated Show resolved Hide resolved
nextjs/server-side-rendering/.env.example Outdated Show resolved Hide resolved
nextjs/server-side-rendering/app/oauth/route.ts Outdated Show resolved Hide resolved
@christyjacob4 christyjacob4 merged commit 0c7aa7e into master May 31, 2024
@christyjacob4 christyjacob4 deleted the feat-server-side-rendering branch May 31, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants