This repository has been archived by the owner on Sep 29, 2023. It is now read-only.
Updated OAuth docs regarding selection of application type #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gewenyu99, you can review this |
gewenyu99
suggested changes
May 19, 2023
Co-authored-by: Vincent (Wen Yu) Ge <wenyu1999@hotmail.com>
gewenyu99
approved these changes
May 23, 2023
gewenyu99
approved these changes
May 23, 2023
gewenyu99
approved these changes
May 29, 2023
| @@ -307,6 +307,11 @@ try await account.createOAuth2Session(provider: "amazon")</code></pre> | |||
| If there is already an active anonymous session, the new session will be attached to it. If there are no active sessions, the server will attempt to look for an account with the same email address as the email received from the OAuth2 provider and attach the new session to the existing account. If no matching account is found - the server will create a new account. | |||
| </p> | |||
|
|
|||
| <div class="notice"> | |||
| <h3>Note</h3> | |||
There was a problem hiding this comment.
On second thought, can you suggest some better titles for this than "Note"? We don't use generic titles like this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the doc regarding selection of application type in OAuth providers
Test Plan
Doc updates
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
Yes