-
Notifications
You must be signed in to change notification settings - Fork 117
added LinkedIn OAuth provider guide #406
base: oauth-providers
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments. Good job!
|
||
## Creating a LinkedIn Developer app | ||
|
||
To use LinkedIn OAuth with Appwrite, you need to create a LinkedIn Developer app. You can do this by following the [How to Implement OAuth](https://learn.microsoft.com/en-us/linkedin/shared/authentication/authorization-code-flow?tabs=HTTPS1#how-to-implement-3-legged-oauth) guide from LinkedIn. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dksie09 As per DM, find a better post?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Steven confirmed it's 3 legged, so should we just keep it this way?
|
||
After you've created your LinkedIn OAuth app, you can head back to your Appwrite console to complete the form in the **Linkedin OAuth2 Settings** modal. | ||
|
||
- Find the **Client ID** in the Auth tab of your LinkedIn developer app and provide this in the **App ID** field in the **Linkedin OAuth2 Settings** modal from the Appwrite console. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Find the **Client ID** in the Auth tab of your LinkedIn developer app and provide this in the **App ID** field in the **Linkedin OAuth2 Settings** modal from the Appwrite console. | |
- Find the **Client ID** in the Auth tab of your LinkedIn developer app. Provide this in the Appwrite console's **Linkedin OAuth2 Settings** modal, in the **App ID** field. |
I would even split this up to be 2 lines for readability.
After you've created your LinkedIn OAuth app, you can head back to your Appwrite console to complete the form in the **Linkedin OAuth2 Settings** modal. | ||
|
||
- Find the **Client ID** in the Auth tab of your LinkedIn developer app and provide this in the **App ID** field in the **Linkedin OAuth2 Settings** modal from the Appwrite console. | ||
- Similarly, find the **Client secret** in the Auth tab of your LinkedIn developer app and provide this in the **App Secret** field in the **Linkedin OAuth2 Settings** modal from the Appwrite console. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto with comment above. Split this up into more lines/sentences for readability.
Try to write in a clear top down hierarchy: [site][modal][field] so it's easier to read.
- Find the **Client ID** in the Auth tab of your LinkedIn developer app and provide this in the **App ID** field in the **Linkedin OAuth2 Settings** modal from the Appwrite console. | ||
- Similarly, find the **Client secret** in the Auth tab of your LinkedIn developer app and provide this in the **App Secret** field in the **Linkedin OAuth2 Settings** modal from the Appwrite console. | ||
|
||
When adding a **Redirect URL** in OAuth 2.0 settings, provide the **URI** found in the **Linkedin OAuth2 Settings** modal from your Appwrite console and click on **Update**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above comments.
|
||
client | ||
.setEndpoint("https://cloud.appwrite.io/v1") // Your API Endpoint | ||
.setProject("[PROJECT_ID]"); // Your project ID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For these examples, try to line up the comments.
client
.setEndpoint("https://cloud.appwrite.io/v1") // Your API Endpoint
.setProject("[PROJECT_ID]"); // Your project ID
Like this ☝️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me.
What does this PR do?
Provides a detailed guide for adding LinkedIn OAuth
Have you read the Contributing Guidelines on issues?
yes