Skip to content
This repository has been archived by the owner on Sep 29, 2023. It is now read-only.

Add more missing variables for GitHub integration #425

Merged
merged 6 commits into from
Sep 3, 2023
Merged

Add more missing variables for GitHub integration #425

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
44944fd
added more variables taht were missing from function GitHub integration
Sep 1, 2023
216a057
Update app/views/docs/configuration.phtml
Sep 1, 2023
b70c175
Update app/views/docs/configuration.phtml
Sep 1, 2023
a8a6788
Update app/views/docs/configuration.phtml
Sep 1, 2023
79a0842
Update app/views/docs/configuration.phtml
Sep 1, 2023
f1e7d28
add example for _APP_DOMAIN_TARGET
Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions app/views/docs/configuration.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,18 @@
</thead>
<tbody>
<tr>
<td><code>http://[HOSTNAME_OR_IP]/v1/vcs/github/callback</code></td>
<td><code>https://[HOSTNAME_OR_IP]/v1/vcs/github/callback</code></td>
</tr>
<tr>
<td><code>http://[HOSTNAME_OR_IP]/v1/account/sessions/oauth2/callback/github/console</code></td>
<td><code>https://[HOSTNAME_OR_IP]/v1/account/sessions/oauth2/callback/github/console</code></td>
</tr>
</tbody>
</table>

<p>
Also select the <b>Request user authentication (OAuth) during installation</b> box.
gewenyu99 marked this conversation as resolved.
Show resolved Hide resolved
</p>

<h3><a href="#post-install" id="post-install">Post Installation</a></h3>
<p>
Check the <b>Redirect on update</b> box under the <b>Post installation</b> section.
Expand Down Expand Up @@ -168,6 +172,29 @@
</tr>
</thead>
<tbody>
<tr>
<td>_APP_DOMAIN</td>
<td>
Your Appwrite domain address.
gewenyu99 marked this conversation as resolved.
Show resolved Hide resolved
When setting a public suffix domain, Appwrite will attempt to issue a valid SSL certificate automatically.
gewenyu99 marked this conversation as resolved.
Show resolved Hide resolved
When used with a dev domain, Appwrite will assign a self-signed SSL certificate.
If you're using a proxy for <b>localhost development</b>, such as <a href="https://ngrok.com/" target="_blank" rel="noopener">ngrok</a>, this will be the domain of your localhost proxy.
</td>
</tr>
<tr>
<td>_APP_DOMAIN_TARGET</td>
<td>
A DNS A-record hostname to serve as a CNAME target for your Appwrite custom domains.
gewenyu99 marked this conversation as resolved.
Show resolved Hide resolved
You can use the same value as used for the Appwrite <code>_APP_DOMAIN</code> variable.
If you're using a proxy for <b>localhost development</b>, such as <a href="https://ngrok.com/" target="_blank" rel="noopener">ngrok</a>, this will be the domain of your localhost proxy, such as <code>dd65-2405-201-4013-d8d7-b4c5-fb73-39f9-285c.ngrok.io</code>.
</td>
</tr>
<tr>
<td>_APP_DOMAIN_FUNCTIONS</td>
<td>
[@steven @khushboo help]
gewenyu99 marked this conversation as resolved.
Show resolved Hide resolved
</td>
</tr>
<tr>
<td>_APP_VCS_GITHUB_APP_NAME</td>
<td>Name of your GitHub app. This is the display name you'll see on GitHub and it will be visible in your GitHub app's URL.</td>
Expand Down