Code overhaul #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SoftCreatR
commented
Sep 25, 2020
SoftCreatR
commented
- Change fully-qualified function calls to namespaced function calls for simplicity. However, the performance gain is so little, that they could be completely removed.
- Declare visibility for constants
- Add return type hints
- Perform small code optimizations
- Re-Format files
- Add missing dependency "ext-sockets" to composer.json
- Update test namespace
- Changed fully-qualified function calls to namespaced function calls for simplicity. However, the performance gain is so little, that they could be completely removed. - Declared visibility for constants - Added return type hints - Performed small code optimizations - Formatted files - Added missing dependency "ext-sockets" to composer.json - Updated test namespace
|
Hey @SoftCreatR, why did you close the PR? changes actually looked pretty good. |
|
Hey, it's just, that I found some more optimization potential. I'll create a new PR, when done :) |
|
👌🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.