-
Notifications
You must be signed in to change notification settings - Fork 56
Asynchronous Python Playground #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Nibba2018 do you think this PR will make a better default example than the synced version? |
@eldadfux , I did some tests and found that this takes the same amount of time to execute compared to the synced version. So I am still a bit doubtful whether this is truly asynchronous. I think we have to implement |
This won't work because there isn't any awaitable coroutine in your asynchronous functions. This will just run synchronously and will take more time then synchronous counterpart due to the additional overhead of the event loop. You have two options to make it asynchronous either by running it in another thread by using run_in_executor or make the underlying library asynchronous. The first one is easy. |
@Niraj-Kamdar , Okay let me try this. |
Hi @eldadfux , I tried a workaround to run python playground asynchronously. Do have a look.
This PR refers to this issue
API Calls