chore: bug fixes for Apwrite 1.4.2

appwrite · Sep 7, 2023 · 7fa595b · 7fa595b
1 parent c3126b7
commit 7fa595b
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 17 deletions.
diff --git a/README.md b/README.md
@@ -1,7 +1,7 @@
 # Appwrite Node.js SDK
 
 ![License](https://img.shields.io/github/license/appwrite/sdk-for-node.svg?style=flat-square)
-![Version](https://img.shields.io/badge/api%20version-1.4.1-blue.svg?style=flat-square)
+![Version](https://img.shields.io/badge/api%20version-1.4.2-blue.svg?style=flat-square)
 [![Build Status](https://img.shields.io/travis/com/appwrite/sdk-generator?style=flat-square)](https://travis-ci.com/appwrite/sdk-generator)
 [![Twitter Account](https://img.shields.io/twitter/follow/appwrite?color=00acee&label=twitter&style=flat-square)](https://twitter.com/appwrite)
 [![Discord](https://img.shields.io/discord/564160730845151244?label=discord&style=flat-square)](https://appwrite.io/discord)

diff --git a/docs/examples/functions/create.md b/docs/examples/functions/create.md
@@ -11,7 +11,7 @@ client
     .setKey('919c2d18fb5d4...a2ae413da83346ad2') // Your secret API key
 ;
 
-const promise = functions.create('[FUNCTION_ID]', '[NAME]', 'node-14.5');
+const promise = functions.create('[FUNCTION_ID]', '[NAME]', 'node-18.0');
 
 promise.then(function (response) {
     console.log(response);

diff --git a/docs/examples/functions/update.md b/docs/examples/functions/update.md
@@ -11,7 +11,7 @@ client
     .setKey('919c2d18fb5d4...a2ae413da83346ad2') // Your secret API key
 ;
 
-const promise = functions.update('[FUNCTION_ID]', '[NAME]', 'node-14.5');
+const promise = functions.update('[FUNCTION_ID]', '[NAME]');
 
 promise.then(function (response) {
     console.log(response);

diff --git a/docs/examples/teams/create-membership.md b/docs/examples/teams/create-membership.md
@@ -11,7 +11,7 @@ client
     .setKey('919c2d18fb5d4...a2ae413da83346ad2') // Your secret API key
 ;
 
-const promise = teams.createMembership('[TEAM_ID]', [], 'https://example.com');
+const promise = teams.createMembership('[TEAM_ID]', []);
 
 promise.then(function (response) {
     console.log(response);

diff --git a/index.d.ts b/index.d.ts
@@ -3279,7 +3279,7 @@ declare module "node-appwrite" {
      * @throws {AppwriteException}
      * @returns {Promise}
      */
-    update(functionId: string, name: string, runtime: string, execute?: string[], events?: string[], schedule?: string, timeout?: number, enabled?: boolean, logging?: boolean, entrypoint?: string, commands?: string, installationId?: string, providerRepositoryId?: string, providerBranch?: string, providerSilentMode?: boolean, providerRootDirectory?: string): Promise<Models.Function>;
+    update(functionId: string, name: string, runtime?: string, execute?: string[], events?: string[], schedule?: string, timeout?: number, enabled?: boolean, logging?: boolean, entrypoint?: string, commands?: string, installationId?: string, providerRepositoryId?: string, providerBranch?: string, providerSilentMode?: boolean, providerRootDirectory?: string): Promise<Models.Function>;
     /**
      * Delete Function
      *
@@ -4028,15 +4028,15 @@ declare module "node-appwrite" {
      *
      * @param {string} teamId
      * @param {string[]} roles
-     * @param {string} url
      * @param {string} email
      * @param {string} userId
      * @param {string} phone
+     * @param {string} url
      * @param {string} name
      * @throws {AppwriteException}
      * @returns {Promise}
      */
-    createMembership(teamId: string, roles: string[], url: string, email?: string, userId?: string, phone?: string, name?: string): Promise<Models.Membership>;
+    createMembership(teamId: string, roles: string[], email?: string, userId?: string, phone?: string, url?: string, name?: string): Promise<Models.Membership>;
     /**
      * Get Team Membership
      *

diff --git a/lib/services/functions.js b/lib/services/functions.js
@@ -247,10 +247,6 @@ class Functions extends Service {
             throw new AppwriteException('Missing required parameter: "name"');
         }
 
-        if (typeof runtime === 'undefined') {
-            throw new AppwriteException('Missing required parameter: "runtime"');
-        }
-
 
         if (typeof name !== 'undefined') {
             payload['name'] = name;

diff --git a/lib/services/teams.js b/lib/services/teams.js
@@ -220,15 +220,15 @@ class Teams extends Service {
      *
      * @param {string} teamId
      * @param {string[]} roles
-     * @param {string} url
      * @param {string} email
      * @param {string} userId
      * @param {string} phone
+     * @param {string} url
      * @param {string} name
      * @throws {AppwriteException}
      * @returns {Promise}
      */
-    async createMembership(teamId, roles, url, email, userId, phone, name) {
+    async createMembership(teamId, roles, email, userId, phone, url, name) {
         const apiPath = '/teams/{teamId}/memberships'.replace('{teamId}', teamId);
         let payload = {};
         if (typeof teamId === 'undefined') {
@@ -239,10 +239,6 @@ class Teams extends Service {
             throw new AppwriteException('Missing required parameter: "roles"');
         }
 
-        if (typeof url === 'undefined') {
-            throw new AppwriteException('Missing required parameter: "url"');
-        }
-
 
         if (typeof email !== 'undefined') {
             payload['email'] = email;