Merge pull request #385 from appwrite/fix-swift-realtime-selfsigned

Fix websocket client not respecting client self signed status

templates/php/src/Services/Service.php.twig

@@ -20,10 +20,10 @@ class {{ service.name | caseUcfirst }} extends Service
      * @param {{ parameter.type | typeName }}${{ parameter.name | caseCamel | escapeKeyword }}
 {% endfor %}
      * @throws {{spec.title | caseUcfirst}}Exception
-     * @return {% if (method.type == 'location') or (method.method | caseUpper == 'DELETE') %}string{% else %}array{% endif %}
+     * @return {% if method.type == 'location' %}string{% else %}array{% endif %}
 
      */
-    public function {{ method.name | caseCamel }}({% for parameter in method.parameters.all %}{{ parameter.type | typeName }}${{ parameter.name | caseCamel | escapeKeyword }}{% if not parameter.required %} = null{% endif %}{% if not loop.last %}, {% endif %}{% endfor %}{% if 'multipart/form-data' in method.consumes %}, callable $onProgress = null{% endif %}): {% if (method.type == 'location') or (method.method | caseUpper == 'DELETE') %}string{% else %}array{% endif %}
+    public function {{ method.name | caseCamel }}({% for parameter in method.parameters.all %}{{ parameter.type | typeName }}${{ parameter.name | caseCamel | escapeKeyword }}{% if not parameter.required %} = null{% endif %}{% if not loop.last %}, {% endif %}{% endfor %}{% if 'multipart/form-data' in method.consumes %}, callable $onProgress = null{% endif %}): {% if method.type == 'location' %}string{% else %}array{% endif %}
 
     {
 {% for parameter in method.parameters.all %}

templates/swift/Sources/Client.swift.twig

@@ -29,6 +29,8 @@ open class Client {
 
     open var config: [String: String] = [:]
 
+    open var selfSigned: Bool = false
+
     open var http: HTTPClient
 
     private static let boundaryChars =
@@ -119,6 +121,7 @@ open class Client {
     /// @return Client
     ///
     open func setSelfSigned(_ status: Bool = true) -> Client {
+        self.selfSigned = status
         try! http.syncShutdown()
         http = Client.createHTTP(selfSigned: status)
         return self

templates/swift/Sources/Services/Realtime.swift.twig

@@ -38,7 +38,7 @@ open class Realtime : Service {
             reconnect = false
             closeSocket()
         } else {
-            socketClient = WebSocketClient(url, delegate: self)!
+            socketClient = WebSocketClient(url, tlsEnabled: !client.selfSigned, delegate: self)!
         }
 
         try! socketClient?.connect()

templates/swift/Sources/WebSockets/WebSocketClient.swift.twig

@@ -172,7 +172,7 @@ public class WebSocketClient {
         frameKey: String,
         headers: HTTPHeaders = HTTPHeaders(),
         maxFrameSize: Int = 14,
-        tlsEnabled: Bool = false,
+        tlsEnabled: Bool = true,
         delegate: WebSocketClientDelegate? = nil
     ) {
         self.host = host
@@ -193,19 +193,19 @@ public class WebSocketClient {
     ///     - delegate:     Delegate to handle message and error callbacks.
     public init?(
         _ url: String,
+        tlsEnabled: Bool = true,
         headers: HTTPHeaders = HTTPHeaders(),
         delegate: WebSocketClientDelegate? = nil
     ) {
         let rawUrl = URL(string: url)
-        let hasTLS =  rawUrl?.scheme == "wss" || rawUrl?.scheme == "https"
         self.frameKey = "tergregfgbsfdgfdsfgdbv=="
         self.host = rawUrl?.host ?? "localhost"
-        self.port = rawUrl?.port ?? (hasTLS ? 443 : 80)
+        self.port = rawUrl?.port ?? (tlsEnabled ? 443 : 80)
         self.uri = rawUrl?.path ?? "/"
         self.query = rawUrl?.query ?? ""
         self.headers = headers
         self.maxFrameSize = 24
-        self.tlsEnabled = hasTLS
+        self.tlsEnabled = tlsEnabled
         self.delegate = delegate
     }