chore: fix response attribute from AppwriteException #1031
+133
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loks0n
reviewed
Jan 24, 2025
templates/android/library/src/main/java/io/package/exceptions/Exception.kt.twig
Outdated
Show resolved
Hide resolved
templates/kotlin/src/main/kotlin/io/appwrite/exceptions/Exception.kt.twig
Outdated
Show resolved
Hide resolved
ChiragAgg5k
force-pushed
the
fix-execption-response
branch
from
b0991da to
1447dba
Compare
ChiragAgg5k
changed the title
loks0n
reviewed
Jan 27, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Also Swift and Dotnet tests are failing, can you look into it? |
ChiragAgg5k
force-pushed
the
fix-execption-response
branch
from
fbc1eb1 to
6e45683
Compare
ChiragAgg5k
changed the title
ChiragAgg5k
changed the title
ChiragAgg5k
force-pushed
the
fix-execption-response
branch
from
6e45683 to
1ec4519
Compare
ChiragAgg5k
changed the title
loks0n
approved these changes
Feb 6, 2025
| @@ -490,7 +490,7 @@ class Client @JvmOverloads constructor( | |||
| body | |||
| ) | |||
| } else { | |||
| {{ spec.title | caseUcfirst }}Exception(body, response.code) | |||
| {{ spec.title | caseUcfirst }}Exception(body, response.code, "", body) | |||
There was a problem hiding this comment.
Should we set the type (third) parameter?
There was a problem hiding this comment.
when the response is in plain text, we don't have a type returned by the backend. we can manually set it as type: text, but that conveys the message was expected to be of type text, which it wasn't
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
responseattribute in AppwriteException seems to sometimes be anobjecteven though it should be a string. This PR fixes typing for response attribute and adds relevant tests for it.Test Plan
androidappleclidartdenodotnetfluttergokotlinnodephppythonreact-nativerestrubyswiftwebRelated PRs and Issues
responseprop ofAppwriteExceptiondeclaresstring, but the response is actually anobject#1017Have you read the Contributing Guidelines on issues?
Yes.