fix: type generation templates to include relative path and strict flag #1112
+92
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Meldiron
reviewed
Jul 22, 2025
Meldiron
reviewed
Jul 22, 2025
Meldiron
reviewed
Jul 22, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR improves the Appwrite CLI type generation system by fixing path handling and relationship type generation. The changes enhance the user experience by displaying relative paths instead of absolute paths in generated comments and fixing relationship type resolution to use collection names instead of IDs.
- Replaces absolute paths with relative command paths in generated type files
- Fixes relationship type generation to use collection names instead of
$id - Adds
--strictflag information to regeneration commands
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| templates/cli/lib/type-generation/languages/typescript.js.twig | Updates getType method signature and fixes relationship type resolution |
| templates/cli/lib/type-generation/languages/swift.js.twig | Similar updates for Swift language support |
| templates/cli/lib/type-generation/languages/php.js.twig | PHP language template updates with relationship fixes |
| templates/cli/lib/type-generation/languages/kotlin.js.twig | Kotlin template improvements |
| templates/cli/lib/type-generation/languages/javascript.js.twig | JavaScript template modifications |
| templates/cli/lib/type-generation/languages/java.js.twig | Java language template updates |
| templates/cli/lib/type-generation/languages/dart.js.twig | Dart template fixes and improvements |
| templates/cli/lib/commands/types.js.twig | Command handler updates to pass collections parameter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
$id--strictflag to comments when types are generated in strict modeTest Plan
Have you read the Contributing Guidelines on issues?
yes.