Updated typescript template generator to use Models.DocumentBase #1113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The appwrite-cli type generation for TypeScript defined a Document type as:
However, by extending
Models.Document
, the[key: string]: any
still allows attributes that don't exist.To solve this, PR appwrite/appwrite#10171 adds the
DocumentBase
type that defines the default attributes of a Document.The type-generator can then use this type to define the specific types for the collections.
Test Plan
Did not write any tests (yet); Let me know if you think this is needed.
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
yes