feat: generics support for dart #1114
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements generics support for the Dart SDK generation, specifically adding type parameter support for models with dynamic data properties and their associated services. The changes enable better type safety when working with documents and collections that can contain custom data structures.
Key changes include:
- Enhanced model classes to support generic type parameters for dynamic data properties
- Updated service methods to accept type conversion functions for generic models
- Modified template logic to handle underscore-prefixed properties with appropriate getters
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| templates/dart/lib/src/models/model.dart.twig | Adds generic type support to model classes with conditional type parameters and property handling |
| templates/dart/test/src/models/model_test.dart.twig | Updates test generation to handle underscore-prefixed properties in generic models |
| templates/dart/lib/services/service.dart.twig | Modifies service methods to support generic return types and type conversion functions |
| templates/dart/base/requests/api.twig | Updates API response handling to pass type conversion functions to generic models |
| src/SDK/Language/Dart.php | Implements helper methods for detecting generic types and generating property types |
| src/SDK/Language/Kotlin.php | Fixes return type annotation from string to bool for consistency |
| example.php | Updates to use separate specifications for different platform targets |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
add generics support to dart lang
Test Plan
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
yes.