fix: config typing #1232
Merged
fix: config typing #1232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughThe PR makes three focused changes in templates/web source files: (1) adds an explicit type annotation to the Client class's public Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (184)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
templates/web/src/client.ts.twig(2 hunks)templates/web/src/services/realtime.ts.twig(1 hunks)
🔇 Additional comments (2)
templates/web/src/client.ts.twig (1)
485-485: Verify that session property is properly typed.Removing optional chaining on
configis correct sinceconfigis a required class property. However, ensure the index signature correctly reflects thatconfig.sessionmight beundefined(see comment on lines 303-307).templates/web/src/services/realtime.ts.twig (1)
370-370: Verify that session property is properly typed.Removing optional chaining on
configis correct sinceconfigis a required property on the Client class. However, this change depends on the correct typing of theconfigobject's index signature intemplates/web/src/client.ts.twig. Ensure that the type correctly reflects thatconfig.sessionmight beundefined(see related comment in client.ts.twig, lines 303-307).
There was a problem hiding this comment.
Pull Request Overview
This PR fixes TypeScript typing issues in the client configuration by making the config property have explicit type annotations instead of being implicitly typed. The change removes optional chaining (?.) when accessing config.session since config is now guaranteed to be non-nullable.
- Changed
configfrom an implicitly typed object to an explicitly typed object with required properties - Updated session access to remove optional chaining since config is no longer optional
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| templates/web/src/client.ts.twig | Added explicit type annotation for config property and removed optional chaining when accessing config.session |
| templates/web/src/services/realtime.ts.twig | Removed optional chaining when accessing this.client.config.session |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ChiragAgg5k
force-pushed
the
fix-annotation
branch
from
fbf3e9e to
d17a631
Compare
abnegate
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes:
Summary by CodeRabbit