Feat android response models #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -77,7 +77,7 @@ class SDKTest extends TestCase | |||
| 'chmod +x tests/sdks/android/gradlew', | |||
| ], | |||
| 'envs' => [ | |||
| 'java-8' => 'docker run --rm -v $(pwd):/app -w /app/tests/sdks/android alvrme/alpine-android:latest-jdk8 sh -c "./gradlew :library:testReleaseUnitTest -q && cat library/result.txt"', | |||
| 'java-11' => 'docker run --rm -v $(pwd):/app -w /app/tests/sdks/android alvrme/alpine-android:latest-jdk11 sh -c "./gradlew :library:testReleaseUnitTest -q && cat library/result.txt"', | |||
There was a problem hiding this comment.
does this no longer support java 8?
There was a problem hiding this comment.
The library can still be used on Java 8 - we are just compiling with 11 (stable Android Studio does now too)
|
@lohanidamodar I've pushed a snapshot on dev 🙂 |
christyjacob4
requested changes
Nov 2, 2021
| ext.kotlin_version = "1.4.31" | ||
| version '{{ sdk.version }}' | ||
| ext.kotlin_version = "1.5.31" | ||
| version "{{ sdk.version }}" |
There was a problem hiding this comment.
Are double quotes and single quotes treated similarly ?
There was a problem hiding this comment.
Yep they are the same except allow for interpolation. I changed for consistency but I see there's other I missed anyway
lohanidamodar
approved these changes
Nov 3, 2021
…se-models # Conflicts: # templates/android/library/src/main/java/io/appwrite/Client.kt.twig
christyjacob4
approved these changes
Nov 8, 2021
TorstenDittmann
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Android response models
Update dependencies
Update to Java 11
Target Android 12