Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(deno): response models #306

Merged
merged 4 commits into from
Nov 12, 2021
Merged

feat(deno): response models #306

merged 4 commits into from
Nov 12, 2021

Conversation

TorstenDittmann
Copy link
Contributor

@TorstenDittmann TorstenDittmann commented Nov 2, 2021 •
edited
Loading

Generated models.d.ts and the account service for example => https://gist.github.com/TorstenDittmann/2ed14650762f9e621138d4ad21038eb5

lohanidamodar
lohanidamodar reviewed Nov 9, 2021
View reviewed changes
Copy link
Member

@lohanidamodar lohanidamodar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except for the fact about nested generics that you pointed out.

@TorstenDittmann TorstenDittmann merged commit ba8f87c into master Nov 12, 2021
@TorstenDittmann TorstenDittmann deleted the feat-deno-response-models branch November 12, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lohanidamodar lohanidamodar lohanidamodar left review comments

@christyjacob4 christyjacob4 christyjacob4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TorstenDittmann @lohanidamodar @christyjacob4