Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modification for flutter web auth 0.4.0 #325

Merged
merged 7 commits into from
Dec 16, 2021
Merged

modification for flutter web auth 0.4.0 #325

merged 7 commits into from
Dec 16, 2021

Conversation

Silfalion
Copy link
Contributor

@Silfalion Silfalion commented Dec 13, 2021

These modifications allow taking advantage of flutter_web_auth new features for flutter web which is to open a new tab for authentication instead of using the in-use one.

This pull request includes:

  • bumping flutter web auth version to 0.4.0.
  • adding the cookijar variable as well as imports in client_browser.dart.
  • implementing web_auth in client_browser.dart.
  • removing the condition at the end of the createOAuth2Session method in account.dart.

Copy link
Member

@lohanidamodar lohanidamodar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thank you for the PR,
Let's handle these changes 🙏🏻

templates/flutter/lib/src/client_browser.dart.twig Outdated Show resolved Hide resolved
templates/flutter/lib/src/client_browser.dart.twig Outdated Show resolved Hide resolved
@lohanidamodar
Copy link
Member

Also seems there is some conflict, please sync with master and fix it

@lohanidamodar lohanidamodar self-assigned this Dec 13, 2021
updated pubspec yaml for conflicts
@Silfalion
Copy link
Contributor Author

Silfalion commented Dec 13, 2021

Hey thank you for the PR,
Let's handle these changes 🙏🏻

My pleasure.

Fixed the remaining conflicts for the pubspec.yaml file but the remaining one is about flutter_web_auth bump to 0.4.0

@lohanidamodar
Copy link
Member

@Silfalion just removed some extra white spaces, and updated path_provider. Will let the tests pass and then merge.

@Silfalion
Copy link
Contributor Author

@lohanidamodar awesome, thank you!

@lohanidamodar lohanidamodar merged commit 6185cdf into appwrite:master Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants